Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending linting #696

Closed
rankida opened this issue Apr 4, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@rankida
Copy link
Contributor

@rankida rankida commented Apr 4, 2017

Hi.

I have created a eslint plugin for lab https://www.npmjs.com/package/eslint-plugin-lab and I have been thwarted rolling it out because in the lab documentation it shows a global install (here)[https://github.com/hapijs/lab#usage] but if I add my plugin to my .eslintrc file, as described in the (lab documentation)[https://github.com/hapijs/lab#extending-the-linter] then when my colleagues use the global install it fails to look in the local collection of plugins, even though it is picking up the local .eslintrc file.

Is this by design? How is it recommended to extend the linter for global usages?

@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented Apr 4, 2017

It should be removed, it's not a good practice to use lab globally. Past that, loading of the plugins is left to eslint, so I guess the note in http://eslint.org/docs/user-guide/configuring#configuring-plugins applies.

@geek geek added the documentation label Apr 4, 2017
@geek geek self-assigned this Apr 4, 2017
@geek geek added this to the 13.0.2 milestone Apr 4, 2017
@geek geek closed this in 5bfeb49 Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.