Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 8 will add `WebAssembly` global #697

Closed
cjihrig opened this issue Apr 12, 2017 · 12 comments
Closed

Node 8 will add `WebAssembly` global #697

cjihrig opened this issue Apr 12, 2017 · 12 comments
Assignees
Labels
Milestone

Comments

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 12, 2017

The leaks will need to be updated for this.

@geek geek added the feature label Apr 13, 2017
@geek geek self-assigned this May 8, 2017
@geek geek added this to the 13.0.5 milestone May 8, 2017
@geek geek closed this in #704 May 9, 2017
alloy added a commit to alloy/ts-babel-node that referenced this issue Jun 8, 2017
orta added a commit to danielmoore/ts-babel-node that referenced this issue Jun 12, 2017
@danielo515

This comment has been minimized.

Copy link

@danielo515 danielo515 commented Nov 21, 2017

This report is poor and does not help in any way.
Which versions of hapi are affected ? From which version is it fixed ?
Regards

@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented Nov 21, 2017

Nice necrobumping. The report is clear, so is the fix, who said it affected hapi, and the version is on the right.

@danielo515

This comment has been minimized.

Copy link

@danielo515 danielo515 commented Nov 21, 2017

@Marsup I didn't saw the the milestone thing, my bad.

I said that affects hapi by mistake, I wanted to say joi

@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented Nov 21, 2017

Again, what does it have to do with joi ?

@danielo515

This comment has been minimized.

Copy link

@danielo515 danielo515 commented Nov 21, 2017

Dam! I don't know what happens today with my connection between my brain and my hands, sorry. lab, lab, I mean lab. Sorry for the double confusion

@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented Nov 21, 2017

Lab is also not affected, node 8+ is, which the report says.

@danielo515

This comment has been minimized.

Copy link

@danielo515 danielo515 commented Nov 21, 2017

Then I will re-say that the report is not clear. Is not clear if this is a new vulnerability which needs to be added to the list of vulnerabilities, or if its a bug that reports a fake vulnerability and it only happens on node 8, or if it is a vulnerability in node 8 itself. Maybe for people familiar with the project one line is enough to understand what is it about, but not for the rest of us.

@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented Nov 21, 2017

What makes you think it's a vulnerability?

@danielo515

This comment has been minimized.

Copy link

@danielo515 danielo515 commented Nov 21, 2017

This sentence:

The leaks will need to be updated for this.

Regards

@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented Nov 21, 2017

Lab contains leak detection, that's all there is to it.

@danielo515

This comment has been minimized.

Copy link

@danielo515 danielo515 commented Nov 21, 2017

I think this will be easier if you explain me what is the intention of the issue, and I'll be very grateful

@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented Nov 21, 2017

I literally just did, lab contains leak detection, there's a new global in node 8, we add it to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.