Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include code assertion library #712

Closed
geek opened this issue May 31, 2017 · 3 comments
Assignees
Milestone

Comments

@geek
Copy link
Member

@geek geek commented May 31, 2017

Most users of lab use code, we should include it and export the expect function from lab. Additionally, we should default to code as the assertion library when running tests. People should be able to opt-out of code as the assertion library as they can today. This will be breaking as the default test behavior will change to enable assertion checks by default

@geek geek self-assigned this May 31, 2017
@geek geek added this to the 14.0.0 milestone May 31, 2017
@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented May 31, 2017

What is it trying to fix ? I haven't seen people complaining about this.

@geek

This comment has been minimized.

Copy link
Member Author

@geek geek commented May 31, 2017

@Marsup I was speaking with a couple of lab users and that was one of their biggest gripes, since most users of lab are also using code, it does make sense.

@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented May 31, 2017

OK, felt like 5.0 was coming back to haunt us :) (looking at the PR it's not quite that)

@geek geek closed this in #713 Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.