Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upInclude code assertion library #712
Comments
This comment has been minimized.
This comment has been minimized.
|
What is it trying to fix ? I haven't seen people complaining about this. |
This comment has been minimized.
This comment has been minimized.
|
@Marsup I was speaking with a couple of lab users and that was one of their biggest gripes, since most users of lab are also using code, it does make sense. |
This comment has been minimized.
This comment has been minimized.
|
OK, felt like 5.0 was coming back to haunt us :) (looking at the PR it's not quite that) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Most users of lab use code, we should include it and export the expect function from lab. Additionally, we should default to code as the assertion library when running tests. People should be able to opt-out of code as the assertion library as they can today. This will be breaking as the default test behavior will change to enable assertion checks by default