Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14.0.0 Release Notes #719

Closed
geek opened this issue Jun 13, 2017 · 0 comments
Assignees
Milestone

Comments

@geek
Copy link
Member

@geek geek commented Jun 13, 2017

Breaking Changes

  • The code assertion module is now included with lab and enabled by default for calculating assertion counts. That being said, there isn't a requirement to use code for assertions, and all other assertion libraries continue to be compatible. The breaking change is that assertion counts are output by default now.

  • ESLint is updated to version 4.0.0, which includes a few breaking changes. Please refer to the migration notes from ESLint for advice on what changes to look for.

  • When writing a test you must either return a Promise or a function accepting a callback. Previously, if you returned a promise that also resolved the callback function you would get an error, so this is a change to make that mistake more obvious. For example, the following now results in an error:

it('will error when returning a promise and accepting a callback function', (done) => {
  return new Promise((resolve) => {
    resolve();
  }).then(() => done());
});

Instead, if you return a promise do not accept a callback argument.

it('will work when returning a promise', () => {
  return new Promise((resolve) => {
    resolve();
  });
});

... or don't use promises at all:

it('will work with a callback', (done) => {
  done();
});
@geek geek added this to the 14.0.0 milestone Jun 13, 2017
@geek geek self-assigned this Jun 13, 2017
@geek geek closed this Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.