Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add an explanation of verbosity; what does 'verbosity: 3.00' mean? #737

Closed
jcollum-cambia opened this issue Aug 18, 2017 · 3 comments
Assignees
Milestone

Comments

@jcollum-cambia
Copy link

@jcollum-cambia jcollum-cambia commented Aug 18, 2017

I found it in the PR notebook.assertions / totalTests, so I'm doing 3 assertions per test on average.

OK, but what does it mean? Is more verbosity good? Is there a number that's considered "good enough"? I'm just curious because I've never heard this term before.

Googling for it just brings up a ton of python pages.

@geek

This comment has been minimized.

Copy link
Member

@geek geek commented Aug 19, 2017

What is considered good is largely up to you and your preference. Some people prefer that a test is very specific and only testing one thing, which means the verbosity level should be very low. If a test has a large number of assertions then the reasons for a failure may be more complex to determine than a test with a single assertion. The verbosity number is a good indicator of tests becoming overly complex. Again, this is entirely up to you and what you prefer as well as what you are testing, some tests will naturally have a lot of asserts.

@geek geek added the question label Aug 19, 2017
@geek geek self-assigned this Aug 19, 2017
@geek geek closed this Aug 20, 2017
@jcollum-cambia

This comment has been minimized.

Copy link
Author

@jcollum-cambia jcollum-cambia commented Aug 22, 2017

I think it would be worth an addition to your docs. As I said, google isn't any help here. Still isn't, even after adding this issue.

@geek geek reopened this Aug 22, 2017
@geek geek added the documentation label Aug 22, 2017
@jcollum-cambia

This comment has been minimized.

Copy link
Author

@jcollum-cambia jcollum-cambia commented Aug 22, 2017

geek added the documentation label a minute ago

Thanks 👍

@geek geek added this to the 14.2.1 milestone Aug 25, 2017
@geek geek closed this in #743 Aug 25, 2017
@Marsup Marsup added support and removed question labels Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.