Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transforming files does not work with yarn workspaces #823

Closed
pdziok opened this issue Mar 30, 2018 · 0 comments
Closed

Transforming files does not work with yarn workspaces #823

pdziok opened this issue Mar 30, 2018 · 0 comments
Assignees
Labels
bug
Milestone

Comments

@pdziok
Copy link
Contributor

@pdziok pdziok commented Mar 30, 2018

Hey 馃憢
Got striked with rather rare error while using lab transform option - calculated relative path for the file to be transformed was looking like: dules/babel-plugin-transform-object-rest-spread/lib/index.js

Issue was the fact that I was using yarn workspaces and some of the packages was required from the root dir's node_modules of the repository and was used in a sub directory/workspace.

Issue was caused at https://github.com/hapijs/lab/blob/master/lib/transform.js#L63. Replacing it with path.relative solved the problem for me.

I'd be happy to provide PR fixing this issue.

@geek geek added the bug label May 7, 2018
@geek geek added this to the 15.4.3 milestone May 7, 2018
@geek geek self-assigned this May 7, 2018
@geek geek closed this in #824 May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.