Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage fails for multiple conditionals on same line (logical operators) #842

Closed
icetbr opened this issue Jun 28, 2018 · 3 comments
Assignees
Labels
bug
Milestone

Comments

@icetbr
Copy link

@icetbr icetbr commented Jun 28, 2018

Hi, I think this is a known issue. If so, it might me useful to leave this open or fix through a known issues doc.

labcoverage

Related
gotwarlost/istanbul#311
sc-forks/solidity-coverage#175

@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented Jun 28, 2018

Coverage checks for truthy and falsy case, you're only covering the truthy case according to the color, it was written in the tooltip.

@icetbr

This comment has been minimized.

Copy link
Author

@icetbr icetbr commented Jun 28, 2018

I could have been more specific. My issue is that the same test reports differently for the two styles of code that represent the same thing.

request.quey.c should have been green.

This would give me 100% cover
a = true
b = true
c = true

a = true
b = false
c = true

a = false
b = false
c = true

@geek geek self-assigned this Nov 13, 2018
@geek geek added the bug label Nov 13, 2018
@geek geek added this to the 18.0.0 milestone Nov 13, 2018
@geek

This comment has been minimized.

Copy link
Member

@geek geek commented Nov 13, 2018

In the latest lab this case is now correctly detected: #878

@geek geek closed this Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.