Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console reporter: "gray" is actually light green #852

Closed
rluba opened this issue Aug 23, 2018 · 1 comment
Assignees
Labels
bug
Milestone

Comments

@rluba
Copy link
Contributor

@rluba rluba commented Aug 23, 2018

Is it intentional that the console reporter defines "gray" as color code 92? Because 92 is actually "bright green" – at least on my machines and also by any definition I could find.

I always wondered about the strange color scheme of lab, but thought it was caused by the OSX terminal theme or something. While working on my recent PR, I finally took a closer look and found that strange definition of gray.

Maybe 37 or 90 would be more appropriate?

@geek geek added the bug label Nov 4, 2018
@geek geek self-assigned this Nov 10, 2018
@geek geek added this to the 18.0.0 milestone Nov 10, 2018
@geek geek closed this in #883 Nov 12, 2018
@rluba

This comment has been minimized.

Copy link
Contributor Author

@rluba rluba commented Nov 16, 2018

Thanks, @geek. This looks way better now! 🙇‍♂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.