Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linter configuration? #855

Closed
zemccartney opened this issue Aug 30, 2018 · 1 comment
Closed

Update linter configuration? #855

zemccartney opened this issue Aug 30, 2018 · 1 comment
Assignees
Labels
bug
Milestone

Comments

@zemccartney
Copy link

@zemccartney zemccartney commented Aug 30, 2018

Hey there!

Curious if it's worth updating the linter's configuration file, given that eslint deprecated the ecmaFeatures property in v5 (https://eslint.org/docs/user-guide/migrating-to-5.0.0#-the-experimentalobjectrestspread-option-has-been-deprecated)?

Concretely, this'd just mean dropping that property and bumping ecmaVersion to 9 (or 2018)
I'm out of context, tho! No idea if any project-specific reasons not to do that.

Regardless, thanks for all the work here! lab's been a pleasure to use, appreciate all the time that's gone into making it 🙏

@geek geek added the bug label Nov 12, 2018
@geek geek added this to the 18.0.0 milestone Nov 12, 2018
@geek geek self-assigned this Nov 12, 2018
@geek

This comment has been minimized.

Copy link
Member

@geek geek commented Nov 12, 2018

Fixed by #890

@geek geek closed this Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.