Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stupid typescript #938

Closed
hueniverse opened this issue Sep 1, 2019 · 2 comments
Closed

Stupid typescript #938

hueniverse opened this issue Sep 1, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented Sep 1, 2019

Changing error codes without major because I guess they don't think anyone should be using error codes programmatically...

New error code 2769 added.

For people who care about strict typing, this is fucking absurd...

Disclaimer: I'm at the end of an 11 hours flight and this is not the kind of shit I need to solve 20 minutes before landing so I can fix a cascade of bugs in other modules.

@hueniverse hueniverse added this to the 20.2.2 milestone Sep 1, 2019
@hueniverse hueniverse self-assigned this Sep 1, 2019
@hueniverse hueniverse closed this in ff951b9 Sep 1, 2019
@kanongil

This comment has been minimized.

Copy link
Member

@kanongil kanongil commented Sep 2, 2019

You should probably fix the typescript dependency to a major + minor version since typescript does not follow semver. See microsoft/TypeScript#14116.

@hueniverse

This comment has been minimized.

Copy link
Member Author

@hueniverse hueniverse commented Sep 2, 2019

Good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.