Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat failure count at end of errors listing. #113

Closed
wants to merge 1 commit into from

Conversation

@bradobro
Copy link

bradobro commented Jul 8, 2014

Use case: We have some covered code and introduce a feature we know will cause regression errors. We run lab under nodemon and want to burn down the error count as we fix the regressions.

This is just a minimally invasive fix, 'editor inheritance' of the existing failure count report.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jul 16, 2014

I am not following why you need to repeat this information.

@bradobro

This comment has been minimized.

Copy link
Author

bradobro commented Jul 16, 2014

I don't need the information repeated; I think it's more useful near the end.

      at Object._onImmediate (/Users/brado/Documents/wc/elasticbible/plugin/elasticbible-web/node_modules/lab/lib/execute.js:492:17)
      at processImmediate [as _immediateCallback] (timers.js:336:15)

  20) group authorization (permissions) there is a group that is free for non-commercial apps:

      AssertionError: expected [Error: No duplicate app groups allowed: free] to be null
      Message: No duplicate app groups allowed: free

      at /Users/brado/Documents/wc/elasticbible/plugin/elasticbible-web/test/biblegroup.js:229:30

6 of 21 tests failed:


 No global variable leaks detected.

16 Jul 08:31:53 - [nodemon] app crashed - waiting for file changes before starting...

If I introduce a change that breaks a lot of tests, an initial pass-fail count summary will scroll be scrolled off by the many lines of error listings.

Sometimes I need those details and will scroll up to them, but more likely, I want my eye on the error count as I make the fixes. I'll have a pane running nodemon node_modules/lab/bin/lab while I edit and save.

I know people have different workflows. This change will probably only appeal to more BDD/TDD flows. It's just a gentle request, "If you have no strong preference, could we put the summary at the bottom?"

Thanks for considering.

@hueniverse hueniverse added this to the 4.0.0 milestone Aug 1, 2014
@hueniverse hueniverse self-assigned this Aug 1, 2014
@hueniverse hueniverse closed this Aug 1, 2014
@bradobro

This comment has been minimized.

Copy link
Author

bradobro commented Aug 1, 2014

Thanks for considering the request, Eran.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.