Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook updates #136

Merged
merged 7 commits into from Aug 7, 2014

Conversation

@arb
Copy link
Contributor

arb commented Aug 6, 2014

Fixes #129

@geek geek added this to the 4.0.0 milestone Aug 6, 2014
@geek geek added the enhancement label Aug 6, 2014
@geek geek self-assigned this Aug 6, 2014
output += 'Session errors:\n\n';
for (var i = 0, il = errors.length; i < il; ++i) {
var error = errors[i];
var message = error.message || error;

This comment has been minimized.

Copy link
@geek

geek Aug 6, 2014

Member

message, stack, and index are declared multiple times in this scope


// remove node_modules folders and only show the first 5 lines of the stack
stack = stack.split('\n').filter(function (line) {
return !(/\/node_modules\//.test(line));

This comment has been minimized.

Copy link
@geek

geek Aug 6, 2014

Member

newline after function

arb added 2 commits Aug 7, 2014
@arb

This comment has been minimized.

Copy link
Contributor Author

arb commented Aug 7, 2014

@wpreul should be all set.

@geek geek added ready and removed ready labels Aug 7, 2014
geek added a commit that referenced this pull request Aug 7, 2014
Notebook updates
@geek geek merged commit b4eae0a into hapijs:master Aug 7, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.