Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with missing labCov reference #144

Merged
merged 3 commits into from Aug 8, 2014

Conversation

@geek
Copy link
Member

geek commented Aug 8, 2014

Fixes #143

@geek geek added the in progress label Aug 8, 2014
@geek geek added this to the 4.0.1 milestone Aug 8, 2014
@geek geek added the test label Aug 8, 2014
@geek geek assigned arb Aug 8, 2014
@geek

This comment has been minimized.

Copy link
Member Author

geek commented Aug 8, 2014

For clarification on the fix:

this is in the node repl

> var report = __$$labCov
ReferenceError: __$$labCov is not defined
    at repl:1:14
    at REPLServer.defaultEval (repl.js:130:27)
    at bound (domain.js:257:14)
    at REPLServer.runBound [as eval] (domain.js:270:12)
    at REPLServer.<anonymous> (repl.js:277:12)
    at REPLServer.EventEmitter.emit (events.js:107:17)
    at REPLServer.Interface._onLine (readline.js:202:10)
    at REPLServer.Interface._line (readline.js:531:8)
    at REPLServer.Interface._ttyWrite (readline.js:812:14)
    at ReadStream.onkeypress (readline.js:101:10)
> var report = global.__$$labCov
undefined
@geek geek removed the in progress label Aug 8, 2014
arb added a commit that referenced this pull request Aug 8, 2014
Fixing issue with missing labCov reference
@arb arb merged commit 8601669 into hapijs:master Aug 8, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.