Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to test environment #150

Merged
merged 1 commit into from Aug 11, 2014
Merged

Default to test environment #150

merged 1 commit into from Aug 11, 2014

Conversation

@geek
Copy link
Member

geek commented Aug 11, 2014

Closes #148

This was a regression from the previous version of lab where it defaulted to 'test':

process.env.NODE_ENV = argv.e || 'test';

@geek geek added the bug label Aug 11, 2014
@geek geek added this to the 4.0.2 milestone Aug 11, 2014
arb added a commit that referenced this pull request Aug 11, 2014
Default to test environment
@arb arb merged commit ac80b9b into hapijs:master Aug 11, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Aug 11, 2014

If I may, this fixes the regression, not the underlying bug : providing a custom environment wouldn't work either. But thanks for the quick response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.