Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating TAP reporter to specification version 13 #163

Merged
merged 2 commits into from Aug 20, 2014

Conversation

@swaj
Copy link
Contributor

swaj commented Aug 15, 2014

First, this adds the functionality in #119.

Second, the "TODO" and "SKIP" reports were not implemented properly as directives. According to the spec, directives must come after a # symbol.

Finally, since the YAML block can be used to describe any data structure, I moved the stack trace for errors into a multi-line string so it would be compliant with the YAML specification.

Let me know if you have any questions or if this commit needs some cleanup.

Cheers!

@@ -58,5 +69,4 @@ internals.Reporter.prototype.end = function (notebook) {
this.report('# fail ' + this.failures + '\n');
this.report('# skipped ' + this.skipped + '\n');
this.report('# todo ' + this.todo + '\n');
};

};

This comment has been minimized.

Copy link
@geek

geek Aug 19, 2014

Member

missing newline

@geek geek added the enhancement label Aug 19, 2014
@geek geek added this to the 4.1.0 milestone Aug 19, 2014
@geek geek self-assigned this Aug 19, 2014
@swaj

This comment has been minimized.

Copy link
Contributor Author

swaj commented Aug 20, 2014

Sorry about the missing newline. It should be fixed now.

geek added a commit that referenced this pull request Aug 20, 2014
Updating TAP reporter to specification version 13
@geek geek merged commit f3d8aca into hapijs:master Aug 20, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.