Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Prevent clobbered timer globals from interfering with runner #164

Merged
merged 2 commits into from Aug 19, 2014

Conversation

@miloconway
Copy link

miloconway commented Aug 18, 2014

Sinon.js exposes a functionality that mocks global timing functions. This change will save a reference to the global timing functions to prevent subsequent clobbering from affecting runner.js

See also: https://github.com/visionmedia/mocha/blob/master/lib/runnable.js#L10-L18

@chapel

…subsequent global clobbering

describe('Runner', function () {
var poisonPill = function () {

This comment has been minimized.

Copy link
@geek

geek Aug 19, 2014

Member

Please add a newline after each function declaration: https://github.com/hapijs/hapi/blob/master/docs/Style.md

This comment has been minimized.

Copy link
@miloconway

miloconway Aug 19, 2014

Author

@wpreul newline added

@geek geek added this to the 4.1.0 milestone Aug 19, 2014
@geek geek self-assigned this Aug 19, 2014
geek added a commit that referenced this pull request Aug 19, 2014
Feature - Prevent clobbered timer globals from interfering with runner
@geek geek merged commit fbe07f4 into hapijs:master Aug 19, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@geek geek mentioned this pull request Aug 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.