Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ignore option and document alias arguments #199

Merged
merged 1 commit into from Sep 12, 2014

Conversation

@geek
Copy link
Member

geek commented Sep 12, 2014

Fixes #196

@geek geek added the feature label Sep 12, 2014
@geek geek added this to the 4.4.0 milestone Sep 12, 2014
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Sep 12, 2014

Isn't this a breaking change since it used to be --globals? https://github.com/hapijs/lab/blob/master/lib/cli.js#L151-L154 I think you should include globals as an additional alias.

@geek

This comment has been minimized.

Copy link
Member Author

geek commented Sep 12, 2014

It still works with --globals

arb added a commit that referenced this pull request Sep 12, 2014
Add --ignore option and document alias arguments
@arb arb merged commit f72d199 into hapijs:master Sep 12, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@geek geek assigned arb Sep 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.