Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #178: Add sourcemaps support #207

Merged
merged 1 commit into from Sep 22, 2014

Conversation

@Marsup
Copy link
Member

Marsup commented Sep 13, 2014

Follow-up of the #178 discussion.

@geek geek added the feature label Sep 15, 2014
@geek geek modified the milestones: 4.5.0, 4.4.4 Sep 15, 2014
@geek

This comment has been minimized.

Copy link
Member

geek commented Sep 22, 2014

I'll merge this, it just needs an update to the readme to document the new flag.

Thanks.

@geek geek self-assigned this Sep 22, 2014
@Marsup Marsup force-pushed the Marsup:sourcemaps branch from 03a728c to 47c532c Sep 22, 2014
@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented Sep 22, 2014

@geek done, I've also rebased so you can fast forward.

geek added a commit that referenced this pull request Sep 22, 2014
Fix #178: Add sourcemaps support
@geek geek merged commit cc2d589 into hapijs:master Sep 22, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented Sep 25, 2014

@geek My bad, I missed adding 'sourcemaps' on cli.js:231, can you do that and release a 4.5.1 please ?

@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented Sep 25, 2014

Oh god, I did several mistakes on my latest patches, I'm sending a quick fix.

@Marsup Marsup deleted the Marsup:sourcemaps branch Sep 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.