Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #209: omit undefined options #212

Merged
merged 1 commit into from Sep 16, 2014
Merged

Fix #209: omit undefined options #212

merged 1 commit into from Sep 16, 2014

Conversation

@Marsup
Copy link
Member

Marsup commented Sep 16, 2014

Undefined options out of bossy are all set to undefined, just checking for hasOwnProperty is not enough.
Since everything was defined, all timeouts were overridden to undefined, so nothing was waiting for the tests to finish, hence the even loop was dry, which caused the #209 premature exit.
Hope that was clear :)

@Marsup Marsup force-pushed the Marsup:fix209 branch from 908ff8f to 5c5ba81 Sep 16, 2014
@nlf

This comment has been minimized.

Copy link
Member

nlf commented Sep 16, 2014

Nice catch!

@geek geek added the bug label Sep 16, 2014
@geek geek added this to the 4.5.0 milestone Sep 16, 2014
@geek geek self-assigned this Sep 16, 2014
geek added a commit that referenced this pull request Sep 16, 2014
Fix #209: omit undefined options
@geek geek merged commit 2c20fae into hapijs:master Sep 16, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@Marsup Marsup deleted the Marsup:fix209 branch Sep 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.