Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional timeouts on before(Each), after(Each) #215

Merged
merged 1 commit into from Sep 24, 2014

Conversation

@Marsup
Copy link
Member

Marsup commented Sep 21, 2014

This should fix #211. I didn't know what to pick as CLI switch name so if you have a better idea I'll change.

@hueniverse hueniverse added the feature label Sep 21, 2014
@geek geek added this to the 4.5.0 milestone Sep 22, 2014
@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented Sep 24, 2014

@geek doesn't it feel weird to you to have options at the end of the block? Writing it this way seems more aligned with how it's done in the other parts of the API.

@geek

This comment has been minimized.

Copy link
Member

geek commented Sep 24, 2014

@Marsup I see your point, ok sounds good as is then. Thanks.

geek added a commit that referenced this pull request Sep 24, 2014
Add optional timeouts on before(Each), after(Each)
@geek geek merged commit 7770c60 into hapijs:master Sep 24, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@Marsup Marsup deleted the Marsup:context-timeout branch Sep 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.