Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint arg is now a boolean #241

Merged
merged 1 commit into from Oct 9, 2014

Conversation

@geek
Copy link
Member

geek commented Oct 9, 2014

Closes #237

@geek geek assigned arb Oct 9, 2014
@geek geek added this to the 4.6.2 milestone Oct 9, 2014
@geek geek added the feature label Oct 9, 2014
arb added a commit that referenced this pull request Oct 9, 2014
Lint arg is now a boolean
@arb arb merged commit b53c648 into hapijs:master Oct 9, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented on fc56701 Oct 11, 2014

May I ask why ?

This comment has been minimized.

Copy link
Member

hueniverse replied Oct 11, 2014

Only one linter was provided, and there really is no reason to support others. This is a simple bundle like chai using the most common solution. There is no extra value in allowing extensions here because you can accomplish it by adding them in your Makefile. I asked to change it because typing -L eslint felt silly.

This comment has been minimized.

Copy link
Member

Marsup replied Oct 11, 2014

So you won't ever want to lint your css or any other kind of files with lab ? I get it but in the current state of linters, most people don't use only one.

This comment has been minimized.

Copy link
Member

hueniverse replied Oct 11, 2014

Well, if the use case for multiple linters come up, we can consider it. We can always make -L flexible to have a default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.