Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run linting in child process #247

Merged
merged 7 commits into from Oct 17, 2014

Conversation

@geek
Copy link
Member

geek commented Oct 10, 2014

Closes #245

@geek geek added the feature label Oct 10, 2014
@geek geek added this to the 4.6.3 milestone Oct 10, 2014
@geek geek added bug and removed feature labels Oct 10, 2014
@geek

This comment has been minimized.

Copy link
Member Author

geek commented Oct 16, 2014

@hueniverse should be good to go now

lib/lint.js Outdated

process.chdir(cwd);
var child = ChildProcess.fork(__dirname + '/linters/eslint/index.js');
child.once('message', function (message) {

This comment has been minimized.

Copy link
@Marsup

Marsup Oct 16, 2014

Member

@geek you might as well use the cwd option of the fork instead of the trick I had to do.

@geek

This comment has been minimized.

Copy link
Member Author

geek commented Oct 17, 2014

@hueniverse should be good to go

hueniverse added a commit that referenced this pull request Oct 17, 2014
Run linting in child process
@hueniverse hueniverse merged commit fe37c1f into hapijs:master Oct 17, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.