Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Map, Set, and WeakSet to the Harmony globals and improve testing #271

Merged
merged 1 commit into from Nov 6, 2014

Conversation

@cjihrig
Copy link
Contributor

cjihrig commented Nov 6, 2014

The Map and Set Harmony globals were not being tracked at all. Also moved WeakSet with the other Harmony globals. Modified the tests to not overwrite existing globals with 1 and then delete them. Tested on stable, latest, and 0.12 development branch.

@cjihrig cjihrig added this to the 5.0.2 milestone Nov 6, 2014
@geek geek self-assigned this Nov 6, 2014
geek added a commit that referenced this pull request Nov 6, 2014
Add Map, Set, and WeakSet to the Harmony globals and improve testing
@geek geek merged commit a344930 into hapijs:master Nov 6, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@cjihrig cjihrig deleted the cjihrig:harmony branch Nov 6, 2014
@geek geek added bug and removed feature test labels Nov 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.