Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix before/after exceptions to be reported #278
Conversation
hueniverse
added a commit
that referenced
this pull request
Nov 22, 2014
Fix before/after exceptions to be reported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
geek commentedNov 21, 2014
Fixes #277
@hueniverse what do you think of this solution? It wraps calls to
before/afterin a domain so that we can know when they have exceptions and can report them. Otherwise, if an error occurs in anafterthe process exits with code 0.This will need to go into a higher version, maybe 5.1.0 ?