Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix before/after exceptions to be reported #278

Merged
merged 2 commits into from Nov 22, 2014

Conversation

@geek
Copy link
Member

geek commented Nov 21, 2014

Fixes #277

@hueniverse what do you think of this solution? It wraps calls to before/after in a domain so that we can know when they have exceptions and can report them. Otherwise, if an error occurs in an after the process exits with code 0.

This will need to go into a higher version, maybe 5.1.0 ?

geek added 2 commits Nov 21, 2014
@geek geek added bug feature and removed bug labels Nov 21, 2014
hueniverse added a commit that referenced this pull request Nov 22, 2014
Fix before/after exceptions to be reported
@hueniverse hueniverse merged commit d750082 into hapijs:master Nov 22, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@geek geek added this to the 5.0.4 milestone Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.