Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make linter pluggable #290

Merged
merged 2 commits into from Jan 8, 2015
Merged

make linter pluggable #290

merged 2 commits into from Jan 8, 2015

Conversation

@smikes
Copy link
Contributor

smikes commented Jan 7, 2015

initial work: jslint runs but writes to stdout instead of returning data
update tests to use -L, -n to specify linter
style: remove dangling comma
spacing and intentation
rename linter output to "lint" from "eslint"
implement runner; add tests, fixtures for jslint
restore newlines
hoist helper functions
add jslint (w/version) as optional dependency

initial work: jslint runs but writes to stdout instead of returning data
update tests to use -L, -n to specify linter
style: remove dangling comma
spacing and intentation
rename linter output to "lint" from "eslint"
implement runner; add tests, fixtures for jslint
restore newlines
hoist helper functions
add jslint (w/version) as optional dependency
@geek geek added the feature label Jan 7, 2015
@geek geek self-assigned this Jan 7, 2015
@geek geek added this to the 5.1.1 milestone Jan 7, 2015
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jan 7, 2015

Isn't this a 5.2.0?

@geek

This comment has been minimized.

Copy link
Member

geek commented Jan 8, 2015

@hueniverse yes, hadn't got to reviewing fully to make that switch. Thanks.

@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Jan 8, 2015

For what it's worth, I still believe a single switch is achievable :p

@smikes

This comment has been minimized.

Copy link
Contributor Author

smikes commented Jan 8, 2015

@Marsup My impression was that bossy did not want the logic needed to support a single switch. Easier for me to make 1 PR than two connected ones; if you want to resurrect the other PR, that's fine by me.

@geek I agree with this as a minor version bump, 5.2.0 would be awesome :-)

};

var formatFile = function (file) {
return {

This comment has been minimized.

Copy link
@geek

geek Jan 8, 2015

Member

Our styles a little different, 4 spaces and a newline after each function declaration.

@smikes

This comment has been minimized.

Copy link
Contributor Author

smikes commented Jan 8, 2015

More like that?

geek added a commit that referenced this pull request Jan 8, 2015
make linter pluggable
@geek geek merged commit f285b6f into hapijs:master Jan 8, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@geek

This comment has been minimized.

Copy link
Member

geek commented Jan 8, 2015

@smikes perfect, thanks

I'll publish this later tonight. Want to run through it all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.