Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add debug option to show domain error stack #318

Merged
merged 3 commits into from Mar 3, 2015

Conversation

@jedireza
Copy link
Contributor

jedireza commented Mar 3, 2015

In hopes to close #294, this PR adds the -D, --debug option. Change requests and feedback welcome.

});
});

Lab.execute(script, { D: true }, null, function (err, notebook) {

This comment has been minimized.

Copy link
@jedireza

jedireza Mar 3, 2015

Author Contributor

Something strange I noticed. If I use debug insead of D like this:

Lab.execute(script, { debug: true }, null, function (err, notebook) {

I get the console artifacts printed to the command line.

Update: Sorry, it must be debug to actually follow the right branch.

@geek geek added the feature label Mar 3, 2015
@geek geek added this to the 5.4.0 milestone Mar 3, 2015
@geek geek self-assigned this Mar 3, 2015
@geek

This comment has been minimized.

Copy link
Member

geek commented Mar 3, 2015

@jedireza thanks for the help, I restarted travis, it has a finicky test in v0.10

geek added a commit that referenced this pull request Mar 3, 2015
add debug option to show domain error stack
@geek geek merged commit 1fb46a0 into hapijs:master Mar 3, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.