Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix domain not exited #322

Merged
merged 1 commit into from Mar 5, 2015

Conversation

@Marsup
Copy link
Member

Marsup commented Mar 5, 2015

Hi @geek,

Found out a possible fix for the bug we discussed on gitter.
I have a hard time figuring out a test for it but this works.

@Marsup Marsup force-pushed the Marsup:domain-bug branch from 0da6870 to 7955e16 Mar 5, 2015
@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented Mar 5, 2015

Well it doesn't fix my bug at work, but that's still something.
The clearTimeout has no effect, I still get the test timeout after the 1st error is thrown by a domain, I don't understand...

@geek geek mentioned this pull request Mar 5, 2015
@geek geek added the bug label Mar 5, 2015
@geek geek added this to the 5.5.0 milestone Mar 5, 2015
@geek geek self-assigned this Mar 5, 2015
geek added a commit that referenced this pull request Mar 5, 2015
Fix domain not exited
@geek geek merged commit 50113b0 into hapijs:master Mar 5, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented Mar 6, 2015

@geek FWIW maybe I was wrong on this one, see https://github.com/joyent/node/blob/master/lib/events.js#L134-L135.
It doesn't hurt calling it multiple times anyway.

@Marsup Marsup deleted the Marsup:domain-bug branch Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.