Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML reporter when using live-transformed code #341

Merged
merged 1 commit into from Apr 20, 2015

Conversation

@ldesplat
Copy link
Contributor

ldesplat commented Apr 10, 2015

This will allow the HTML reporter (and others) to display the transformed code. The display now makes much more sense, and the right lines are highlighted.

@jedireza raised this earlier this week along.
@romeovs raised it too in issue #338 but this does not fix 338. Though it does fix the weird line numbers (line 1 being repeated) raised later on!

screen shot 2015-04-09 at 9 38 23 pm

Before, it would have highlighted an irrelevant line like so
screen shot 2015-04-09 at 9 40 48 pm

… with html reporter
@jedireza

This comment has been minimized.

Copy link
Contributor

jedireza commented Apr 10, 2015

Thanks so much 🙏

@hueniverse hueniverse added the bug label Apr 14, 2015
@geek geek added this to the 5.6.0 milestone Apr 20, 2015
@geek geek self-assigned this Apr 20, 2015
geek added a commit that referenced this pull request Apr 20, 2015
Fix HTML reporter when using live-transformed code
@geek geek merged commit 51441d6 into hapijs:master Apr 20, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.