Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint thresholds #350

Merged
merged 2 commits into from Apr 27, 2015

Conversation

@Marsup
Copy link
Member

Marsup commented Apr 25, 2015

On my way I un-ignored test files, it seems important that they go through linting as well.
Since we're out of short handles for CLI, well, none.

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Apr 25, 2015

👍 I like that tests can fail on linting, will make PR's so much easier.

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Apr 26, 2015

There is still b, q, j, k, u :P those don't really make sense but if timeout can have -m...
Also I should not read PR's at 10am in the weekend :D @Marsup

@geek geek added this to the 5.7.1 milestone Apr 27, 2015
@geek geek added the feature label Apr 27, 2015
@geek geek self-assigned this Apr 27, 2015
@geek

This comment has been minimized.

Copy link
Member

geek commented Apr 27, 2015

@Marsup well done, this looks solid.

geek added a commit that referenced this pull request Apr 27, 2015
Lint thresholds
@geek geek merged commit 9e53e14 into hapijs:master Apr 27, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Marsup Marsup deleted the Marsup:lint-thresholds branch Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.