Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #351. Add message about threshold and npm error message. #352

Merged
merged 1 commit into from Apr 27, 2015

Conversation

@apipkin
Copy link
Contributor

apipkin commented Apr 26, 2015

Addresses the npm ERR! Exit status 1 error message.

Not certain if this is the right place or if there should be a troubleshooting section.

Hard return to maintain apparent line wrapping.

@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Apr 26, 2015

It's also the case if anything fails, so tests, coverage, and linting when the PR is accepted.

@geek geek added the documentation label Apr 27, 2015
@geek geek added this to the 5.8.0 milestone Apr 27, 2015
@geek geek self-assigned this Apr 27, 2015
@geek

This comment has been minimized.

Copy link
Member

geek commented Apr 27, 2015

Closes #351

geek added a commit that referenced this pull request Apr 27, 2015
Fix #351. Add message about threshold and npm error message.
@geek geek merged commit c81bc9c into hapijs:master Apr 27, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.