Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage on loop labels. Fixes #355. #356

Merged
merged 2 commits into from May 12, 2015

Conversation

@Marsup
Copy link
Member

Marsup commented May 12, 2015

No description provided.

@Marsup Marsup added the bug label May 12, 2015
@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented May 12, 2015

@geek it seems travis is very tired right now, I can't see any of those errors on any environment.

@geek geek added this to the 5.8.1 milestone May 12, 2015
@geek geek self-assigned this May 12, 2015
@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented May 12, 2015

OK after re-installing my deps it seems to be a breaking change in diff. Fixing.

@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented May 12, 2015

@geek Ready to go.

@geek

This comment has been minimized.

Copy link
Member

geek commented May 12, 2015

yay

@geek

This comment has been minimized.

Copy link
Member

geek commented May 12, 2015

Thanks @Marsup, I had just ran into this issue locally :)

geek added a commit that referenced this pull request May 12, 2015
Fix coverage on loop labels. Fixes #355.
@geek geek merged commit bb6dc3d into hapijs:master May 12, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Marsup Marsup deleted the Marsup:loop-labels branch May 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.