Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default both linting thresholds to 0. #362

Merged
merged 1 commit into from May 19, 2015
Merged

Default both linting thresholds to 0. #362

merged 1 commit into from May 19, 2015

Conversation

@Marsup
Copy link
Member

Marsup commented May 19, 2015

Fixes #361.

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented May 19, 2015

maybe add some info in the docs that when linting is enabled it will fail the tests if linting warnings/errors are found

Fixes #361.
@Marsup Marsup force-pushed the Marsup:zero-lint branch from ca9814e to eeaf760 May 19, 2015
@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented May 19, 2015

Sort of done.

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented May 19, 2015

hmm that only suggest that when not provided a value it defaults to 0, it should really say that enabling linting will result in enabling those options

@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented May 19, 2015

That's implied by "defaults to".

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented May 19, 2015

I know but it could be read as 'defaults to 0 if the option is used but no value is specified'. Maybe nitpicking but just my thought

@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented May 19, 2015

We'll see if @geek wants a better wording, it's clear enough for me.

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented May 19, 2015

👍

@geek geek added the feature label May 19, 2015
@geek geek added this to the 5.8.2 milestone May 19, 2015
@geek geek self-assigned this May 19, 2015
geek added a commit that referenced this pull request May 19, 2015
Default both linting thresholds to 0.
@geek geek merged commit b9d95ef into hapijs:master May 19, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Marsup Marsup deleted the Marsup:zero-lint branch May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.