Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting update #366

Merged
merged 5 commits into from Jun 9, 2015

Conversation

@AdriVanHoudt
Copy link
Contributor

AdriVanHoudt commented May 26, 2015

  • updates eslint to 0.22.x
    • added lines-around-comment and object-curly-spacing rules
  • updates jslint to 0.9.x
  • removed linting thresholds because they are default now
  • linting test are more strict
  • added container based travis as per outmoded/hapi-contrib#30
@AdriVanHoudt AdriVanHoudt changed the title Linting update [broken] Linting update May 30, 2015
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor Author

AdriVanHoudt commented May 31, 2015

Eslint 0.22.1 was just released so I'll update to that before you can merge

@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented May 31, 2015

I think we should ping @geek now that it's working :)

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor Author

AdriVanHoudt commented May 31, 2015

I bumped to eslint 0.22.x and added the new rules that applied to the styleguide
lines-around-comment however does not support No empty line before when following { unless other rules require it so atm it just forces the empty line (you could use /* */) if you want but styleguide forbids usage of that
Also npm install on iojs failed in tests not the tests themselves

@geek

This comment has been minimized.

Copy link
Member

geek commented Jun 3, 2015

I restarted the job. Thanks for the help on this.

@geek geek added this to the 5.9.1 milestone Jun 3, 2015
@geek geek self-assigned this Jun 3, 2015
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor Author

AdriVanHoudt commented Jun 3, 2015

Tests are all passing and no problem!

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor Author

AdriVanHoudt commented Jun 3, 2015

You want me to squash the commits?

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor Author

AdriVanHoudt commented Jun 8, 2015

Is there anything needed from me to merge?

geek added a commit that referenced this pull request Jun 9, 2015
Linting update
@geek geek merged commit 7b46deb into hapijs:master Jun 9, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.