Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use no-shadow lint rule #371

Merged
merged 4 commits into from Jun 19, 2015

Conversation

@geek
Copy link
Member

geek commented Jun 10, 2015

Remove IE8 rule and use broader no-shadow with a warning

Fixes #369

@geek geek added the feature label Jun 10, 2015
@geek geek added this to the 5.11.0 milestone Jun 10, 2015
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jun 10, 2015

What's with all the forEach replacements?

@geek

This comment has been minimized.

Copy link
Member Author

geek commented Jun 12, 2015

@hueniverse I was wondering what you would say about those :)

We were using them elsewhere in the code, and I wanted to be a little more consistent and contain the variables in the scope a little more.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jun 13, 2015

Ok. Was just unrelated to the issue being fixed.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jun 13, 2015

What's with all the done -> finished?

@geek

This comment has been minimized.

Copy link
Member Author

geek commented Jun 13, 2015

In the tests that was to avoid shadowing done, however, it may be more appropriate as next... do you have a preference?

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jun 13, 2015

done should be the actual test where next or testDone should be the code being tested.

@geek

This comment has been minimized.

Copy link
Member Author

geek commented Jun 18, 2015

@hueniverse I updated the test script tests to use testDone instead of finished, see what you think.

hueniverse added a commit that referenced this pull request Jun 19, 2015
Use no-shadow lint rule
@hueniverse hueniverse merged commit 69e126b into hapijs:master Jun 19, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jagoda added a commit to jagoda/vision that referenced this pull request Jul 7, 2015
Lab enabled the [no-shadow rule](http://eslint.org/docs/rules/no-shadow.html)
in hapijs/lab#371 (with exceptions provided by hapijs/lab#379).
This change corrects lint errors created by variable shadowing.
@jagoda jagoda mentioned this pull request Jul 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.