Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable code coverage support with ES6 #386

Merged
merged 1 commit into from Jul 2, 2015
Merged

enable code coverage support with ES6 #386

merged 1 commit into from Jul 2, 2015

Conversation

@jmonster
Copy link
Contributor

jmonster commented Jun 25, 2015

features enabled

  • arrowFunctions
  • templateStrings
  • blockBindings
  • generators
  • forOf
  • binaryLiterals
  • octalLiterals

There are additional options that could be enabled as well: https://github.com/eslint/espree#usage but I have elected to enable the ones I use most heavily and supported under iojs or node12; I'm unsure what, if any, negative consequence there may be to enabling them all by default.

This PR resolves issues raised at #358 (comment)

blockBindings: true,
arrowFunctions: true,
templateStrings: true,
defaultParams: true

This comment has been minimized.

Copy link
@juhaelee

juhaelee Jun 26, 2015

Can you add generators too?

This comment has been minimized.

Copy link
@jmonster

jmonster Jun 26, 2015

Author Contributor

I'm down for adding them all -- whatsayyou @geek ?

@geek

This comment has been minimized.

Copy link
Member

geek commented Jun 30, 2015

I was talking with @cjihrig and he suggested we add a .labrc type file. I think thats going to be useful for making lab more flexible to cases like this.

Feel free to add generators to the list and I will merge in.

@geek geek added the feature label Jun 30, 2015
@geek geek self-assigned this Jun 30, 2015
@jmonster jmonster force-pushed the jmonster:es6 branch from 86cea3a to 60556cd Jul 1, 2015
…gs and default params

There are additional options that could be enabled as well:
https://github.com/eslint/espree#usage
@jmonster jmonster force-pushed the jmonster:es6 branch from 60556cd to 5fa076f Jul 1, 2015
@jmonster

This comment has been minimized.

Copy link
Contributor Author

jmonster commented Jul 1, 2015

Updated PR to include the following:

  • arrowFunctions
  • templateStrings
  • blockBindings
  • generators
  • forOf
  • binaryLiterals
  • octalLiterals

I selected these particular options since, according to an ES6 compatibility table, they have support in node 12 and iojs. Personally I've only been using the first 3 :)

@geek geek added this to the 5.12.0 milestone Jul 2, 2015
geek added a commit that referenced this pull request Jul 2, 2015
enable code coverage support with ES6
@geek geek merged commit 2bd2c42 into hapijs:master Jul 2, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.