Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach results to the reporter #392

Merged
merged 1 commit into from Jul 2, 2015

Conversation

@geek
Copy link
Member

geek commented Jul 2, 2015

Relates to #389

@geek geek added the bug label Jul 2, 2015
@geek geek added this to the 5.12.0 milestone Jul 2, 2015
@geek geek self-assigned this Jul 2, 2015
@geek

This comment has been minimized.

Copy link
Member Author

geek commented Jul 2, 2015

@hofan41 what do you think of this change?

@hofan41

This comment has been minimized.

Copy link
Contributor

hofan41 commented Jul 2, 2015

Looks good to me! Are there particular rules between when to use internals and when to use self/this?

@geek

This comment has been minimized.

Copy link
Member Author

geek commented Jul 2, 2015

It was more a concern of leaving the results on the static internals for the next time multiple is created... vs keeping the results with the instance.

geek added a commit that referenced this pull request Jul 2, 2015
Attach results to the reporter
@geek geek merged commit 19d5b7b into hapijs:master Jul 2, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hofan41

This comment has been minimized.

Copy link
Contributor

hofan41 commented Jul 2, 2015

Yeah I notice that now too. Good catch!

// Declare internals

var internals = {};


exports = module.exports = internals.Reporter = function (options) {

internals.reporters = [];

This comment has been minimized.

Copy link
@hofan41

hofan41 Jul 2, 2015

Contributor

Shouldn't we do the same with internals.reporters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.