Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a shareable config for ESLint #429

Merged
merged 1 commit into from Aug 24, 2015

Conversation

@cjihrig
Copy link
Contributor

cjihrig commented Aug 24, 2015

No description provided.

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Aug 24, 2015

👏 now I can remove my "extends": "./node_modules/lab/lib/linters/eslint/.eslintrc", lines haha

@devinivy

This comment has been minimized.

Copy link
Member

devinivy commented Aug 24, 2015

This is good news!!

@gergoerdosi

This comment has been minimized.

Copy link
Contributor

gergoerdosi commented Aug 24, 2015

I like this, better than extending ./node_modules/lab/lib/linters/eslint/.eslintrc. However as this config is hapi specific (meaning the hapijs team sets the rules), shouldn't the module (eslint-config-hapi) be under the hapijs organization?

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Aug 24, 2015

@cjihrig is there a way to put the config and plugin into 1 npm module?

@geek

This comment has been minimized.

Copy link
Member

geek commented Aug 24, 2015

@cjihrig I do like the idea of the config being in the hapijs org

@geek geek added the feature label Aug 24, 2015
@geek geek added this to the 5.15.3 milestone Aug 24, 2015
@geek geek self-assigned this Aug 24, 2015
@cjihrig

This comment has been minimized.

Copy link
Contributor Author

cjihrig commented Aug 24, 2015

@AdriVanHoudt not currently. See the discussion in eslint/eslint#2518 and eslint/eslint#3458. I also find it frustrating, but it is what it is.

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Aug 24, 2015

oh gawd...

geek added a commit that referenced this pull request Aug 24, 2015
Use a shareable config for ESLint
@geek geek merged commit 5519fb4 into hapijs:master Aug 24, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cjihrig cjihrig deleted the cjihrig:config branch Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.