Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated eslint version #432

Merged
merged 1 commit into from Sep 3, 2015

Conversation

@dwmkerr
Copy link
Contributor

dwmkerr commented Sep 3, 2015

I noticed a problem when integrating with CodeClimate. My CodeClimate eslint results were different to my Hapi Lab eslint results. When running eslint directly from the commandline I also got different results than with Hapy lab.

It turns out that it was just that a bug with the eslint in memory linter which has already been fixed - but Hapi Lab is fixed to eslint 1.0.x.

I have updated the dependencies to 1.x.x which matches more closely with the other dependencies. Lab now reports exactly the same results as the eslint commandline!

@geek geek added the dependency label Sep 3, 2015
@geek geek self-assigned this Sep 3, 2015
@geek geek added this to the 5.16.1 milestone Sep 3, 2015
geek added a commit that referenced this pull request Sep 3, 2015
Updated eslint version
@geek geek merged commit 9ba1249 into hapijs:master Sep 3, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Sep 3, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.