Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix coverage of trailing function declaration #521
Conversation
This comment has been minimized.
This comment has been minimized.
|
This PR will conflict with #520 because they both insert new tests at the same location in the test suite. Simply resolve it by arranging them in any order. |
This comment has been minimized.
This comment has been minimized.
# Conflicts: # test/coverage.js
This comment has been minimized.
This comment has been minimized.
|
@geek Thx, I’ve resolved the conflict. |
This comment has been minimized.
This comment has been minimized.
|
@rluba well done, looks great. |
geek
added a commit
that referenced
this pull request
Feb 18, 2016
…laration Fix coverage of trailing function declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rluba commentedFeb 18, 2016
Declaring a function after a return statement causes lab to report the declaration as "not covered".
The new test demonstrates the problem: The old coverage code incorrectly reports lines 14 and 21 of
test/coverage/trailing-function-declarations.jsas "not covered". The fix in 2ba2d72 solves this problem by excluding function declarations from tracking.