Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow stdout to flush #541

Merged
merged 1 commit into from Mar 8, 2016
Merged

Allow stdout to flush #541

merged 1 commit into from Mar 8, 2016

Conversation

@Marsup
Copy link
Member

Marsup commented Mar 8, 2016

Because of process.exit, the output doesn't have the time to flush so you get a partial report (many issues about that in the node project).

This fixes it but I don't really have time to find how to cover those lines, I thought it already would be, so if anyone can look into it I'd be grateful.

@Marsup Marsup added the bug label Mar 8, 2016
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Mar 8, 2016

why not just always flush it?

@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented Mar 8, 2016

Because it's only valid if called from L115, otherwise end should take care of it.

@geek geek added this to the 10.2.1 milestone Mar 8, 2016
@geek geek self-assigned this Mar 8, 2016
@geek

This comment has been minimized.

Copy link
Member

geek commented Mar 8, 2016

@Marsup thanks, I will merge and get it covered.

geek added a commit that referenced this pull request Mar 8, 2016
Allow stdout to flush
@geek geek merged commit 8fe7f78 into hapijs:master Mar 8, 2016
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented Mar 8, 2016

BTW, for posterity, it would have been cleaner to check needDrain and listen to drain event, but needDrain is internal, that's why I didn't rely on it.

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Mar 8, 2016

ah missed that!

@rluba rluba mentioned this pull request Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.