Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/silent skips #544

merged 2 commits into from Mar 15, 2016


Copy link

rluba commented Mar 15, 2016

I’ve implemented a silent-skips option to reduce the noise when using .only in large test suites. I hope you like it.

With this in place, we could also remove the special case for ids / glob (see bullet 2 in my only PR and @geek’s response) since the "noisy output" can now be prevented by adding -k when using ids / glob.

This PR also fixes todo tests being reported as complete at the end – even though they are displayed as skipped (-) in the output itself. I caught this by accident when writing the test for the new feature.

master currently contains some uncovered lines from #541 so npm test fails atm.

@geek geek added the feature label Mar 15, 2016
@geek geek self-assigned this Mar 15, 2016
@geek geek added this to the 10.3.0 milestone Mar 15, 2016

This comment has been minimized.

Copy link

geek commented Mar 15, 2016

@rluba well done!

geek added a commit that referenced this pull request Mar 15, 2016
Feature/silent skips
@geek geek merged commit 636e1b3 into hapijs:master Mar 15, 2016
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed

This comment has been minimized.

Copy link

Marsup commented Mar 15, 2016

👍 This is the kind of PR that reminds me we should really consider having a .labrc, those CLI options are getting out of hand. (not that there's anything wrong with this PR)


This comment has been minimized.

Copy link
Contributor Author

rluba commented Mar 15, 2016

@Marsup Yeah, it was not easy to find a free shortcut for the new option — already a pretty long list 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.