Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec style formatting #56

Closed
wants to merge 5 commits into from

Conversation

@krisb
Copy link
Contributor

krisb commented Mar 23, 2014

Adds spec style form output

Incorporates #53 and #55 also

@krisb

This comment has been minimized.

Copy link
Contributor Author

krisb commented Mar 27, 2014

@hueniverse: rebased onto master (2.0.1). Any chance of looking at pulling this or giving me some feedback on it. Thanks.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Mar 29, 2014

This is a pretty intrusive change. Are all those change required to make this work? Also why incorporate two other pull requests into one? It only makes it harder for me to figure out what is going on... Can we please focus on one change at a time :-) I usually get to review these very late in the day so you need to make it easy for my fried brain to follow...

krisb added 5 commits Mar 23, 2014
* added more information about experiments inline with tests
* experiments and tests now have a reference to their parent
* execute tests and experiments as a tree rather than list
* emit start, startExperiment, and endExperiment events
* queried potential issue with deep nested tests and beforeEach/afterEach
@krisb krisb closed this Mar 29, 2014
@krisb

This comment has been minimized.

Copy link
Contributor Author

krisb commented Mar 29, 2014

Clicked the wrong button

@krisb krisb reopened this Mar 29, 2014
@hueniverse hueniverse added this to the 2.1.0 milestone Mar 29, 2014
@hueniverse hueniverse self-assigned this Mar 29, 2014
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Mar 29, 2014

This turned out to be more intrusive than I wanted. Also decided to refactor the reporter file to make new reporter easier. Thanks for the work though.

@hueniverse hueniverse closed this Mar 29, 2014
@krisb krisb deleted the krisb:spec branch Apr 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.