Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upuse stable stringify for better objects diff #573
Merged
+33
−3
Conversation
This comment has been minimized.
This comment has been minimized.
This won't work with a circular object. |
This comment has been minimized.
This comment has been minimized.
what do you mean by 'this won't work'? It should act the same as before (all tests have passed) |
This comment has been minimized.
This comment has been minimized.
My bad, I thought json-stringify-safe was more clever than it really is. |
This comment has been minimized.
This comment has been minimized.
Yes, it just outputs |
lib/reporters/console.js
Outdated
@@ -13,6 +14,12 @@ const internals = { | |||
width: 50 | |||
}; | |||
|
|||
internals.stringify = (obj, serializer, indent, decycler) => { | |||
|
|||
return StableStringify( |
This comment has been minimized.
This comment has been minimized.
Marsup
May 2, 2016
Member
Can't we just do StableStringify(obj, { space: indent, replacer: StringifySafe.getSerialize(serializer) })
?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I would maybe recommend "fast-safe-stringify" as an alternative since I think it's the fastest one out that that doesn't crash on circular references. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@iamdoron well done, this will be a nice improvement for our console reporter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
iamdoron commentedMay 2, 2016
•
edited
instead of:
