Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing invalid markup on filter checkboxes #644

Merged
merged 1 commit into from Sep 22, 2016

Conversation

@ebgranger
Copy link
Contributor

ebgranger commented Sep 22, 2016

The inputs were wrapping the labels for some reason. Most browsers tolerate this markup and construct a valid DOM-tree anyway but I figured I'd fix it in the markup as well.

I thought about wrapping the inputs with the labels as some people recommend both for accessibility. I'll try to spare myself from overthinking a unit test reporter though.

@geek geek added the bug label Sep 22, 2016
@geek geek added this to the 11.0.2 milestone Sep 22, 2016
@geek geek self-assigned this Sep 22, 2016
@geek geek merged commit 8d30730 into hapijs:master Sep 22, 2016
2 checks passed
2 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.