Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't show seed when shuffle was not enabled #662

Merged

Conversation

@rmehner
Copy link
Contributor

rmehner commented Nov 11, 2016

Previously the seed was always shown in the output, even when the order
was not randomized. This could be confusing. With this change, the seed
will only be included in the output if shuffle was enabled.

Previously the seed was always shown in the output, even when the order
was not randomized. This could be confusing. With this change, the seed
will only be included in the output if shuffle was enabled.
@geek geek added the bug label Nov 11, 2016
@geek geek added this to the 11.2.1 milestone Nov 11, 2016
@geek geek self-assigned this Nov 11, 2016
@geek

This comment has been minimized.

Copy link
Member

geek commented Nov 11, 2016

Good catch

@geek geek merged commit 63e649e into hapijs:master Nov 11, 2016
2 checks passed
2 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmehner rmehner deleted the rmehner:fix/do-not-show-seed-when-it-was-not-shuffled branch Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.