Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test and deprecation warning #665

Merged
merged 2 commits into from Jan 12, 2017
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -623,7 +623,7 @@ describe('CLI', () => {
let filename;
beforeEach((done) => {

filename = Path.join(Os.tmpDir(), [Date.now(), process.pid, Crypto.randomBytes(8).toString('hex')].join('-'));
filename = Path.join(Os.tmpdir(), [Date.now(), process.pid, Crypto.randomBytes(8).toString('hex')].join('-'));

This comment has been minimized.

Copy link
@arb

arb Jan 12, 2017

Contributor

Hoek has a unique file name function.

done();
});

@@ -73,6 +73,7 @@ describe('Leaks', () => {
delete global.DTRACE_NET_SERVER_CONNECTION;

const leaks = Lab.leaks.detect();

expect(leaks.length).to.equal(0);

done();
@@ -79,7 +79,7 @@ describe('Reporter', () => {
});
});

const filename = Path.join(Os.tmpDir(), [Date.now(), process.pid, Crypto.randomBytes(8).toString('hex')].join('-'));
const filename = Path.join(Os.tmpdir(), [Date.now(), process.pid, Crypto.randomBytes(8).toString('hex')].join('-'));
Lab.report(script, { output: filename }, (err, code, output) => {

expect(err).to.not.exist();
@@ -102,7 +102,7 @@ describe('Reporter', () => {
});

const randomname = [Date.now(), process.pid, Crypto.randomBytes(8).toString('hex')].join('-');
const folder = Path.join(Os.tmpDir(), randomname);
const folder = Path.join(Os.tmpdir(), randomname);
const filename = Path.join(folder, randomname);
Lab.report(script, { output: filename }, (err, code, output) => {

@@ -126,7 +126,7 @@ describe('Reporter', () => {
});
});

const filename = Path.join(Os.tmpDir(), [Date.now(), process.pid, Crypto.randomBytes(7).toString('hex')].join('-'));
const filename = Path.join(Os.tmpdir(), [Date.now(), process.pid, Crypto.randomBytes(7).toString('hex')].join('-'));
Lab.report(script, { reporter: ['console'], output: [filename] }, (err, code, output) => {

expect(err).to.not.exist();
@@ -2080,7 +2080,7 @@ describe('Reporter', () => {
});

const recorder = new Recorder();
const filename = Path.join(Os.tmpDir(), [Date.now(), process.pid, Crypto.randomBytes(8).toString('hex')].join('-'));
const filename = Path.join(Os.tmpdir(), [Date.now(), process.pid, Crypto.randomBytes(8).toString('hex')].join('-'));

Lab.report(script, { reporter: ['lcov', 'console'], output: [filename, recorder], coverage: true }, (err, code, output) => {

@@ -2122,7 +2122,7 @@ describe('Reporter', () => {
});

const recorder = new Recorder();
const filename = Path.join(Os.tmpDir(), [Date.now(), process.pid, Crypto.randomBytes(8).toString('hex')].join('-'));
const filename = Path.join(Os.tmpdir(), [Date.now(), process.pid, Crypto.randomBytes(8).toString('hex')].join('-'));

Lab.report(script, { reporter: ['console', 'console'], output: [filename, recorder], coverage: true }, (err, code, output) => {

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.