Skip to content

/lab

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --bail support #671

Merged
merged 2 commits into from Jan 18, 2017
Merged

Add --bail support #671

merged 2 commits into from Jan 18, 2017

Conversation

@geek
Copy link
Member

geek commented Jan 17, 2017

Closes #214
@geek
Add --bail support
Loading status checks…
c074671
@geek geek requested review from Marsup and cjihrig Jan 17, 2017
@geek geek added the feature label Jan 17, 2017
@geek geek added this to the 12.0.0 milestone Jan 17, 2017
@geek geek self-assigned this Jan 17, 2017
@Marsup
Marsup reviewed Jan 17, 2017
View changes
Copy link
Member

Marsup left a comment

Don't you think it would be better to mark the remaining tests as skipped, as it's kind of what happened. I also imagine it would be better handled this way if we get multiple failures on tests ran in parallel.
@cjihrig
cjihrig approved these changes Jan 17, 2017
View changes
Copy link
Contributor

cjihrig left a comment

LGTM. No real preference on terminating early or skipping remaining tests.
@geek
Skip instead of abort
Loading status checks…
ae23bc4
@geek

This comment has been minimized.

Sign in to view
Copy link
Member Author

geek commented Jan 18, 2017

@Marsup thanks for the feedback, the PR is updated.
@Marsup

This comment has been minimized.

Sign in to view
Copy link
Member

Marsup commented Jan 18, 2017

Looks even simpler 👍
@Marsup
Marsup approved these changes Jan 18, 2017
View changes
@geek geek merged commit ff5ec50 into hapijs:master Jan 18, 2017
2 checks passed
2 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@geek geek deleted the geek:bail branch Jan 18, 2017
@lerouxb

This comment has been minimized.

Sign in to view
Copy link

lerouxb commented Jan 19, 2017

Great. Now can someone please do a release so I can use this? :)
@geek

This comment has been minimized.

Sign in to view
Copy link
Member Author

geek commented Jan 20, 2017

@lerouxb published!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marsup Marsup

@cjihrig cjihrig

Assignees

@geek geek

Labels
feature
Projects
None yet
Milestone
  12.0.0
4 participants
@geek @Marsup @lerouxb @cjihrig
You can’t perform that action at this time.