Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a domain leak and onCleanup failures #699

Merged
merged 1 commit into from Apr 29, 2017

Conversation

@Marsup
Copy link
Member

Marsup commented Apr 29, 2017

  1. Fixes domain contamination of other tests. On synchronous tests, the done call was still in the domain, so the next before/after/it/... would be contained in previous test. I don't think it lead to bugs but it's still better this way.

  2. onCleanup failures could leave lab hanging infinitely, or worst, crash without reporting anything (out of things to do in the event loop).

@Marsup Marsup added the bug label Apr 29, 2017
@Marsup Marsup requested a review from geek Apr 29, 2017
@geek geek added this to the 13.0.3 milestone Apr 29, 2017
@geek geek merged commit fcf8397 into master Apr 29, 2017
3 checks passed
3 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@geek geek deleted the domain-leak-and-cleanup-crash branch Apr 29, 2017
@geek geek self-assigned this Apr 29, 2017
Copy link
Member

geek left a comment

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.