Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upIgnore while a promise returns inside a test with a value. Only watch for rejection #701
Conversation
lib/runner.js
Outdated
| @@ -743,7 +743,11 @@ internals.protect = function (item, state, callback) { | |||
| if (itemResult && | |||
| itemResult.then instanceof Function) { | |||
|
|
|||
| itemResult.then(done, done); | |||
| itemResult.then(() => { | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@Marsup Your suggested change seems to have caused 2 other tests to fail. Thoughts? |
This comment has been minimized.
This comment has been minimized.
|
Your change doesn't look remotely similar to my suggestion :) |
… for rejection Simplify Try again
This comment has been minimized.
This comment has been minimized.
|
Thanks ! I'll let @geek merge and release as it's not mine to make. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
corbinu commentedMay 1, 2017
Addresses #700 by adding a new test for a resolving promise and then updating the runner to ignore resolved values. Let me know if there are any changes you want me to make :)