Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle code as default assertion library #713

Merged
merged 3 commits into from Jun 5, 2017
Merged

Bundle code as default assertion library #713

merged 3 commits into from Jun 5, 2017

Conversation

@geek
Copy link
Member

geek commented May 31, 2017

Closes #712

@geek geek added this to the 14.0.0 milestone May 31, 2017
@geek geek requested a review from cjihrig May 31, 2017
@geek geek changed the title Bundle code as default assert library Bundle code as default assertion library May 31, 2017
@cjihrig
cjihrig approved these changes Jun 1, 2017
@geek geek force-pushed the geek:master branch from cf43404 to e980049 Jun 5, 2017
@geek

This comment has been minimized.

Copy link
Member Author

geek commented Jun 5, 2017

@cjihrig mind looking again, I added --assert false to support disabling the assertion library from the CLI

@cjihrig
cjihrig approved these changes Jun 5, 2017
Copy link
Contributor

cjihrig left a comment

LGTM with a comment

@@ -439,7 +440,11 @@ internals.options = function () {
options.output = process.stdout;
}

if (options.assert) {
if (options.assert && options.assert.toLowerCase() === 'false') {

This comment has been minimized.

Copy link
@cjihrig

cjihrig Jun 5, 2017

Contributor

Maybe combine the if and else if into a single if (options.assert), then branch inside there.

@geek geek merged commit 3b7478d into hapijs:master Jun 5, 2017
2 checks passed
2 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@geek geek self-assigned this Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.